16 adding contributing.md#55
Merged
Merged
Conversation
wyli
commented
Feb 6, 2020
|
|
||
| ``` | ||
|
|
||
| ## Unit testing |
Contributor
Author
There was a problem hiding this comment.
am i correct on the unit testing? please feel free to push to this branch directly if im wrong @ericspod
atbenmurray
approved these changes
Feb 6, 2020
atbenmurray
left a comment
atbenmurray
left a comment
Contributor
There was a problem hiding this comment.
What is here looks good. I had planned on doing another pass over this to fill in any contributor gaps, but I guess that can happen after we accept the PR
Contributor
Author
Sure, thanks! once @ericspod confirms the unit testing section I think we can safely merge it. |
ericspod
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16.
Description
mainly copying the relevant wiki pages to the main repo.
Status
Ready
Types of changes